#2370: check ShellCommand args against RemoteShellCommand
-------------------------------------+--------------------
Reporter: dustin | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: 0.8.+
Version: 0.8.6p1 | Resolution:
Keywords: reconfig, sprint, simple |
-------------------------------------+--------------------
Description changed by dustin:
Old description:
> Many of the args to !ShellCommand are passed on verbatim to
> !RemoteShellCommand, but this doesn't happen during the configuration
> load, leading to nasty landmines for users.
>
> If possible, we should figure out a way to check these at install time,
> perhaps just by using {{{inspect}}} to see what args
> {{{RemoteShellCommand.__init__}}} takes.
New description:
Many of the args to !ShellCommand are passed on verbatim to
!RemoteShellCommand, but this doesn't happen during the configuration
load, leading to nasty landmines for users.
For example, `ShellCommand(some_unknown_argument=10)` will pass a
configuration check just fine, but will fail when the step runs.
If possible, we should figure out a way to check these at install time,
perhaps just by using {{{inspect}}} to see what args
{{{RemoteShellCommand.__init__}}} takes, and ensuring that the arguments
to !ShellCommand match that set.
--
--
Ticket URL: <http://trac.buildbot.net/ticket/2370#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Free Next-Gen Firewall Hardware Offer
Buy your Sophos next-gen firewall before the end March 2013
and get the hardware for free! Learn more.
http://p.sf.net/sfu/sophos-d2d-feb
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
