#2467: source.SVN incorrectly handles repositories with special character in URL
-------------------+------------------------
Reporter: rutsky | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.7 | Resolution:
Keywords: svn |
-------------------+------------------------
Comment (by rutsky):
"svn info --xml" is unrelated to this issue actually. This bug report
about comparison of Subversion repository URL-s.
Error-prone code is this:
{{{defer.returnValue(extractedurl == self.repourl)}}}
in {{{_sourcedirIsUpdatable()}}} method (buildbot/steps/source/svn.py).
{{{self.repourl}}} is converted in Subversion with
{{{svn_uri_canonicalize()}}} function
(https://svn.apache.org/repos/asf/subversion/trunk/subversion/libsvn_subr/dirent_uri.c),
so correct comparison should look like
{{{defer.returnValue(extractedurl ==
EMULATE_svn_uri_canonicalize(self.repourl))}}}
{{{EMULATE_svn_uri_canonicalize()}}}-like function should be implemented
with same logic as Subversion's {{{svn_uri_canonicalize()}}}.
--
Ticket URL: <http://trac.buildbot.net/ticket/2467#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
