#2485: The New Git Source Step Does Not Handle Changes From GerritChangeSource
Correctly
--------------------+------------------------
Reporter: jroo | Owner:
Type: defect | Status: new
Priority: major | Milestone: undecided
Version: 0.8.7p1 | Keywords: gerrit git
--------------------+------------------------
The implementation from buildbot.steps.sources.Git handles review changes
from GerritChangeSource correctly but the new implementation from
buildbot.steps.sources.git.Git does not.
The following bits should be in master.cfg for reproducing the issue:
{{{
from buildbot.changes.gerritchangesource import GerritChangeSource
c[ 'change_source' ] = [
GerritChangeSource(
gerritserver = 'gerrit.example.com',
gerritport = 29418,
username = 'gerrit-user',
),
]
# ....
c['schedulers'] = [
AnyBranchScheduler(
name = 'all',
change_filter = filter.ChangeFilter( project = 'MyProject' ),
treeStableTimer = None,
builderNames = [
'Some Builder',
],
),
]
# ...
factory = BuildFactory()
factory.addStep( Git(
repourl = GitRepoUrl,
mode = 'update',
submodules = True,
)
)
c[ 'builders' ] = [
BuilderConfig(
name = 'Some Builder',
slavenames = [ 'Slave', ],
mergeRequests = False,
factory = factory,
),
]
}}}
--
Ticket URL: <http://trac.buildbot.net/ticket/2485>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire
the most talented Cisco Certified professionals. Visit the
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
