#2536: GerritStatusPush's reviewCB only passes 4 parameters since 0.8.8
----------------------+------------------------
Reporter: krf | Owner:
Type: undecided | Status: new
Priority: major | Milestone: undecided
Version: master | Keywords: regression
----------------------+------------------------
Just upgraded from 0.8.7 to 0.8.9-pre:
Now I am getting this:
2013-07-29 15:44:44+0200 [-] Exception caught notifying
<buildbot.status.status_gerrit.GerritStatusPush instance at 0x3fba710> of
buildFinished event
2013-07-29 15:44:44+0200 [-] Unhandled Error
Traceback (most recent call last):
File "/home/build/opt/lib/python2.7/site-
packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/build.py",
line 307, in buildFinished
w.callback(self)
File "/usr/local/lib/python2.7/dist-
packages/twisted/internet/defer.py", line 368, in callback
self._startRunCallbacks(result)
File "/usr/local/lib/python2.7/dist-
packages/twisted/internet/defer.py", line 464, in _startRunCallbacks
self._runCallbacks()
File "/usr/local/lib/python2.7/dist-
packages/twisted/internet/defer.py", line 551, in _runCallbacks
current.result = callback(current.result, *args, **kw)
--- <exception caught here> ---
File "/home/build/opt/lib/python2.7/site-
packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/builder.py",
line 535, in _buildFinished
w.buildFinished(name, s, results)
File "/home/build/opt/lib/python2.7/site-
packages/buildbot-0.8.9_pre_5_gd5c6e64-py2.7.egg/buildbot/status/status_gerrit.py",
line 96, in buildFinished
message, verified, reviewed = self.reviewCB(builderName,
build, result, self.reviewArg)
exceptions.TypeError: customGerritReviewCB() takes exactly 5
arguments (4 given)
This commit breaks compatibility for custom GerritStatusPush's reviewCB
implementations when upgrading from 0.8.7 -> 0.8.8:
commit 70002d7b24f5d32c1a4a3650c3b69e1509e164ba
Author: Jacob Stultz <[email protected]>
Date: Fri Jul 27 17:23:29 2012 -0700
Add optional start callback to GerritStatusPush
The source-incompatible change:
(...)
+ message, verified, reviewed = self.reviewCB(builderName, build,
result, self.reviewArg)
(...)
- message, verified, reviewed = self.reviewCB(builderName,
build, result, self.status, self.reviewArg)
This change is not listed in the release notes, so I'm assuming it is not
wanted(?)
--
Ticket URL: <http://trac.buildbot.net/ticket/2536>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
