#2564: "change contains codebase [...] that isnot processed by scheduler" log
message broken
--------------------+--------------------------------
Reporter: dcoshea | Owner:
Type: defect | Status: new
Priority: minor | Milestone: undecided
Version: master | Keywords: schedulers logging
--------------------+--------------------------------
I'm running a Buildbot master from the Git master branch. I noticed that
I have a SingleBranchScheduler whose change_filter accepts changes from
multiple codebases, but whose codebases list did not include all of the
codebases. I checked twistd.log to see if any messages had been logged
about this and found this message:
2013-09-14 08:45:33+0930 [-] Invalid format string or unformattable object
in log message: 'change contains codebase %(codebase)s that isnot
processed by scheduler %(scheduler)s', {'name': 'HIDDEN-1', 'format':
'change contains codebase %(codebase)s that isnot processed by scheduler
%(scheduler)s', 'system': '-', 'codebase': u'HIDDEN-2', 'time':
1379114133.5368111, 'message': (), 'isError': 0}
It looks like both the master and nine branches have this bad code in
buildbot/schedulers/base.py:
{{{
if change.codebase not in self.codebases:
log.msg(format='change contains codebase %(codebase)s that
is'
'not processed by scheduler %(scheduler)s',
codebase=change.codebase, name=self.name)
}}}
Note the two issues with the message:
1. Format string specifies %(scheduler)s but actual parameter has the name
"name".
2. No space between "is" and "not".
Sorry I can't contribute a pull request right now.
--
Ticket URL: <http://trac.buildbot.net/ticket/2564>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
------------------------------------------------------------------------------
LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99!
1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint
2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes
Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13.
http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
