Branch: refs/heads/master
Home: https://github.com/buildbot/buildbot
Commit: 693a2cb7d0f6652d40c29b8b900ac40f2ef1f567
https://github.com/buildbot/buildbot/commit/693a2cb7d0f6652d40c29b8b900ac40f2ef1f567
Author: Роман Донченко <[email protected]>
Date: 2014-03-15 (Sat, 15 Mar 2014)
Changed paths:
M slave/buildslave/runprocess.py
M slave/buildslave/test/unit/test_runprocess.py
Log Message:
-----------
Implement more thorough shell command line escaping on Windows
On Windows, when a command is specified as a list, it's executed via a
batch file. Previously, the shell escaping being done in the process
was quite minimal (only pipes were being escaped), and not entirely
correct (for example, an argument of 'a | b' would get escaped to
'"a ^| b"', which is wrong, since the shell ignores carets inside quotes.
This commit expands the escaping logic to cover all shell special
characters that I know of. For compatibility I kept the exception
that lone pipes are not escaped (although I'd rather I hadn't).
I expanded the test for the embedded pipe symbol into a more generic
special character test, and made it no longer Win32-only, since on any
platform it doesn't hurt to check that special characters in arguments
are correctly passed through.
Commit: 91d92d2a537742c55152a78d562adec5da1f4810
https://github.com/buildbot/buildbot/commit/91d92d2a537742c55152a78d562adec5da1f4810
Author: Роман Донченко <[email protected]>
Date: 2014-03-16 (Sun, 16 Mar 2014)
Changed paths:
M slave/buildslave/runprocess.py
Log Message:
-----------
Use win32_batch_quote in shell_quote
Commit: 1b6bd3effa72b6f4dca6d5da9192116e3aa1698d
https://github.com/buildbot/buildbot/commit/1b6bd3effa72b6f4dca6d5da9192116e3aa1698d
Author: Dustin J. Mitchell <[email protected]>
Date: 2014-03-24 (Mon, 24 Mar 2014)
Changed paths:
M slave/buildslave/runprocess.py
M slave/buildslave/test/unit/test_runprocess.py
Log Message:
-----------
Merge SpecLad/buildbot:win32-shell-escape (PR #1095)
+autopep8
+add r prefix to punctuation string
Compare:
https://github.com/buildbot/buildbot/compare/d6b9ef72d6c5...1b6bd3effa72------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/13534_NeoTech
_______________________________________________
Buildbot-commits mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/buildbot-commits
