[ 
https://issues.apache.org/jira/browse/BUILDR-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576313#action_12576313
 ] 

Nick Sieger commented on BUILDR-54:
-----------------------------------

Ok, be aware that in trunk JRuby we've recently corrected host_os to report 
"mswin32" just as matzruby does (I believe). So your patch looks fine.

> File.normalize_path broken on Mac OS X
> --------------------------------------
>
>                 Key: BUILDR-54
>                 URL: https://issues.apache.org/jira/browse/BUILDR-54
>             Project: Buildr
>          Issue Type: Bug
>          Components: Core features
>    Affects Versions: 1.3
>         Environment: Mac OS X
>            Reporter: Nick Sieger
>            Assignee: Victor Hugo Borja
>            Priority: Blocker
>             Fix For: 1.3
>
>         Attachments: common-mswin.patch
>
>
> The File.normalize_path function introduced in rev 634463 is broken on Mac. 
> The code:
> {noformat}
> Config::CONFIG["host_os"] =~ /win/i
> {noformat}
> is not sufficient to detect Windows, because on Mac OS X:
> {noformat}
> $ ruby -rrbconfig -e 'puts Config::CONFIG["host_os"]'
> darwin9.0
> $ jruby -rrbconfig -e 'puts Config::CONFIG["host_os"]'
> darwin
> {noformat}
> Attached is a patch to fix.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to