[
https://issues.apache.org/jira/browse/BUILDR-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582755#action_12582755
]
Assaf Arkin commented on BUILDR-4:
----------------------------------
I really like the idea of using profiles.yaml, so you could write something
like:
compile.with :spring, :log4j
And specify the dependencies in a YAML file. Easier to edit and doesn't crowd
the buildfile.
I'm not big on the idea of using namespaces, and I wouldn't consider them
better than constants. Consider:
define 'parent' do
define 'one' do
compile.with WL_FOO
end
define 'two' do
compile.with :foo
end
end
I can tell you off the bat project one will only work on WebLogic, it's evident
from the project definition. I can't really tell you what the second one does,
might be the generic foo, or somewhere we override the namespace for project
too, or some extension is overriding the namespace for parent. It takes me a
lot more effort to read the code and understand what it does.
I'm also not convinced it will work well for extension developers. You might
be calling artifact inside the project in one place (e.g. project.compile.with
...) but calling it outside the process at a different place (e.g. using an Ant
task), running with two different libraries that have the very same name. A
single namespace means everybody sees the same extension.
Separately, I don't think changing the version number of an artifact entirely
solves our problem. What happens when building with a new version requires or
enables different options? A better approach would be to give the addon
options to work with, and let it figure out the details. We could do something
like:
options[:xmlbeans] = '2.2'
Or maybe in the profiles.yaml:
common:
xmlbeans: 2.2
> XMLBeans task should use the same XMLBeans version as defined in the project
> ----------------------------------------------------------------------------
>
> Key: BUILDR-4
> URL: https://issues.apache.org/jira/browse/BUILDR-4
> Project: Buildr
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.2.10
> Environment: Buildr 1.2.10
> Reporter: Tammo van Lessen
> Assignee: Victor Hugo Borja
> Fix For: 1.3
>
>
> I recently upgraded Buildr and ran into some issues with Ode.
> Buildr compiles generated classes with XMLBeans 2.3 but Ode uses XMLBeans 2.2
> which is not upward compatible.
> You can reproduce this by compiling the recent ode trunk with Buildr 1.2.10
> and then deploying the war into a tomcat.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
