[
https://issues.apache.org/jira/browse/BUILDR-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Victor Hugo Borja resolved BUILDR-67.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.3.1
Yes, that's the way patches should be submitted (specs and impl on their own
patches ready for `git am`), thanks Tommy.
For simple merges (two branches) I'd recommend using git rebase instead of git
merge, so that commits just get fast-forwarded (retaining the commit messages).
> download(art => 'http://example.com/foo?query') fails to send query part of
> URI when performing the HTTP GET
> ------------------------------------------------------------------------------------------------------------
>
> Key: BUILDR-67
> URL: https://issues.apache.org/jira/browse/BUILDR-67
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.2.10
> Reporter: Tommy Knowlton
> Fix For: 1.3.1
>
> Attachments:
> 0001-Add-a-failing-spec-test-demonstrating-issue-BUILDR.patch,
> 0002-fix-for-BUILDR-67.patch
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> This appears to be caused by inappropriate use of the URI's path member at
> the point where the GET is performed.
> I have already tested a fix that works against 1.2.10 (released) code.
> Also, looking at the trunk code, it appears that this bug remains, although
> the code affected in 1.2.10 has since been rewritten to use Net::HTTP (i.e.,
> the rewrite still uses uri.path when uri.request_uri seems to be more
> correct).
> I *have not* yet created a unit test to fail.
> I'm not clear in my mind about the 'priority' on this, but I'm leaving it at
> 'Major' for now, because it breaks my organization's builds. I don't
> particularly care if the project management team sees fit to move the
> priority down on this.
> I expect to submit one or more patches Real Soon Now (TM).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
