[ 
https://issues.apache.org/jira/browse/BUILDR-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12637000#action_12637000
 ] 

Alex Boisvert commented on BUILDR-156:
--------------------------------------

Hi Marko.  Thanks for the patch!  I agree these are important enhancements and 
I see this issue is already very popular based on the number of votes ;)

Could you split this issue into 3 separate issues?    I think we should tackle 
them separately as I foresee some comments and discussions before the patches 
can be applied.

Second, in order to maintain a high level of quality (and prevent regressions) 
we require tests for all contributions.   Could you provide test cases for each 
of the patches?    (Look under the "spec" directory for inspiration from 
current tests)

> improvement: cobertura:check, download sources and add sourcepath reference 
> to .classpath
> -----------------------------------------------------------------------------------------
>
>                 Key: BUILDR-156
>                 URL: https://issues.apache.org/jira/browse/BUILDR-156
>             Project: Buildr
>          Issue Type: Improvement
>          Components: Core features, Dependency management
>    Affects Versions: 1.3.2
>            Reporter: Marko Sibakov
>             Fix For: 1.3.4
>
>         Attachments: BUILDR-156.batch
>
>
> The attached patch adds the following crucial features to current trunk:
> - cobertura:check
> - downloading source  code attachments for downloaded artifact jars
> - adding source code attachment references to Eclipse .classpath and IDEA 
> .iml files

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to