[ 
https://issues.apache.org/jira/browse/BUILDR-197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644747#action_12644747
 ] 

Ittay Dror commented on BUILDR-197:
-----------------------------------

why call 'super'? even if Rake::Task#needed? returns true, what difference does 
it make? as far as i could see, the prerequisites are not used when creating 
the package. so calling Rake::Task#needed? achieves no functionality, but can 
cause the triggering of the task just because it has a Rake::Task prerequisite 
which was triggered. The ArchiveTask will be triggered, but since it only 
consults its @paths, it will produce the same jar as before (with the same 
content), but with a different timestamp, thus triggering other tasks.

> ArchiveTask#needed? calls 'super' 
> ----------------------------------
>
>                 Key: BUILDR-197
>                 URL: https://issues.apache.org/jira/browse/BUILDR-197
>             Project: Buildr
>          Issue Type: Bug
>          Components: Packaging
>    Affects Versions: 1.3.2
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> At the end of needed? If it found that no re-packaging is required, it still 
> delegates to 'super'. 
> The result is that if there is a Rake::Task prerequisite, with no 
> prerequisites, it will return a Time.now timestamp which will return true 
> from Rake::Task#needed?, which will trigger the package. The package will be 
> the same as before, but its timestamp will change, causing triggering of 
> dependent tasks.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to