[ 
https://issues.apache.org/jira/browse/BUILDR-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644765#action_12644765
 ] 

Ittay Dror commented on BUILDR-198:
-----------------------------------

i don't know about the performance impact, but it is probably no more than 
checking if the directory exists

but the code immediately after is:
      return false if copy_map.empty?

so why not move mkpath after this check? (must the path exist even if empty?)

> Filter#run always calls mkpath
> ------------------------------
>
>                 Key: BUILDR-198
>                 URL: https://issues.apache.org/jira/browse/BUILDR-198
>             Project: Buildr
>          Issue Type: Bug
>    Affects Versions: 1.3.4
>            Reporter: Ittay Dror
>             Fix For: 1.3.4
>
>
> It does this even if it immediately returns. this does call (in linux) the 
> mkdir system call (which returns EEXIST)
> It should also turn off verbose for it

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to