[
https://issues.apache.org/jira/browse/BUILDR-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655878#action_12655878
]
Assaf Arkin commented on BUILDR-222:
------------------------------------
The release process should update_to_version rather than commit_new_snapshot,
since the later was clearly written for SVN. Each source control module could
then do what it thinks is best as part of that version update. Git could then
commit only (which is not equivalent to SVN commit), or it could commit and
push (which should not be done from a method labeled commit).
Similarly, the check_release method does what each source control module thinks
is best for that particular source control system. That's another place where
the forced commonality breaks. SVN's uncommitted file check identifies when
you have local modifications and forces you to synchronize those through the
central repository. A Git uncommitted file check doesn't pack the same punch
(git status != git diff master/origin), so abstracting that method as common
behavior hides the fact that it checks two different things.
Last, Git/Svn are classes but they don't define any instance methods and are
never instantiated; shouldn't these be modules?
> Support Git as a version control system
> ---------------------------------------
>
> Key: BUILDR-222
> URL: https://issues.apache.org/jira/browse/BUILDR-222
> Project: Buildr
> Issue Type: Improvement
> Components: Core features
> Reporter: Alexis Midon
> Attachments: BUILDR-222-0001-git-support-for-release.txt,
> BUILDR-222-0003-git-support-for-release.txt
>
>
> The Release task uses Subversion to check for uncommitted files and tag the
> source repository.
> Of course this fails when your project does not use Subversion but Git for
> instance.
> The improvement could be to provide a VCS abstraction with 2 implementations:
> Subversion and Git.
> A method could instantiate the proper implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
