Hi Robert,

The Shared nodes get their tool locations from 2 places:

1. The Operations Center global Tool Locations config
2. The node itself if a Windows node - overrides Tool Locations dropdown
choices from (1.) by inserting Windows paths

The above ensures that for example someone choosing 'jdk_1.8_latest' in a
DSL / Jenkinsfile etc will get the correct
path whether run on ubuntu or Windows label (or both of course).

Hope the above helps for the curious.
That said, _I did_ need to update the Windows Nodes configs themselves to
match the Operations Center

Thanks for spotting that, hopefully all good now?


On Sun, Oct 18, 2020 at 1:45 PM Robert Scholte <rfscho...@apache.org> wrote:

> Hi Gavin,
>
> Well, it looks like the changes to Jenkins have impact on Windows nodes.
> Looking at https://ci-builds.apache.org/job/Maven/job/maven/configure the
> list of JDKs only contain the new names.
> So either there should still be a list for Windows with the old names, or
> the names also need to be updated for the Windows nodes too.
>
> thanks,
> Robert
>
> On 17-10-2020 19:22:24, Gavin McDonald <gmcdon...@apache.org> wrote:
> Hi Robert,
>
> Separate (I think known) issue, as I never touched the Windows configs,
> will take a look
>
>
>
> On Sat, Oct 17, 2020 at 7:04 PM Robert Scholte wrote:
>
> > On all Windows Nodes I see the following exception (or similar):
> > Error: JAVA_HOME is set to an invalid directory.
> > JAVA_HOME = "/home/jenkins/tools/java/latest1.7"
> > Please set the JAVA_HOME variable in your environment to match the
> > location of your Java installation.
> >
> >
> > It looks like it is picking up the ubuntu JAVA_HOME
> >
> > On 17-10-2020 17:52:56, Gavin McDonald wrote:
> > Hi All,
> >
> > Ok, I'm done for now, please test everyone.
> >
> >
> >
> > On Sat, Oct 17, 2020 at 12:34 PM Gavin McDonald
> > wrote:
> >
> > > Hi All,
> > >
> > > So I'm working through this today. I tested on the ci-infra instance
> and
> > > it seems to the tool locations
> > > checkboxes just disappear after the renaming. But they are still in
> the
> > on
> > > disk configuration, causing
> > > not found errors.
> > >
> > > So I will have to do a find/replace on those items as well.
> > >
> > > ci-builds may be restarted a few times during the process today.
> > >
> > > And, if I miss any config, please let me know.
> > >
> > >
> > > On Tue, Oct 13, 2020 at 8:47 AM Gavin McDonald
> > > wrote:
> > >
> > >> Sorry, still on, I'll get it done today.
> > >>
> > >> On Tue, Oct 13, 2020 at 8:46 AM Zoran Regvart wrote:
> > >>
> > >>> Hi Gavin,
> > >>> from what I can see this hasn't happened yet. I'm guessing the plan
> is
> > >>> still on, but postponed?
> > >>>
> > >>> zoran
> > >>>
> > >>> On Sun, Oct 11, 2020 at 2:03 PM Gavin McDonald
> > >>> wrote:
> > >>> >
> > >>> > As there have been no objections, I will be making this change
> > tomorrow
> > >>> > afternoon UTC at around 5PM
> > >>> >
> > >>> >
> > >>> >
> > >>> > On Thu, Sep 24, 2020 at 3:32 PM P. Ottlinger
> > >>> wrote:
> > >>> >
> > >>> > > Hi Gav,
> > >>> > >
> > >>> > > thanks for the information.
> > >>> > >
> > >>> > > Am 24.09.20 um 12:01 schrieb Gavin McDonald:
> > >>> > > > I think the best approach here is if I do a find replace of
> all
> > >>> these
> > >>> > > as
> > >>> > > > I do the migration.
> > >>> > > > So, there should be nothing for you to do, other than check
> > >>> afterwards
> > >>> > > all
> > >>> > > > is well.
> > >>> > >
> > >>> > > You grep does not help with projects that have their build
> > >>> configuration
> > >>> > > in SCM, such as:
> > >>> > >
> > >>> > >
> https://github.com/apache/creadur-rat/blob/master/Jenkinsfile#L43
> > >>> > >
> > >>> > > But I'll do the proposed changes once you signal the change has
> > been
> > >>> > > applied.
> > >>> > >
> > >>> > > Cheers,
> > >>> > > Phil
> > >>> > >
> > >>> >
> > >>> >
> > >>> > --
> > >>> >
> > >>> > *Gavin McDonald*
> > >>> > Systems Administrator
> > >>> > ASF Infrastructure Team
> > >>>
> > >>>
> > >>>
> > >>> --
> > >>> Zoran Regvart
> > >>>
> > >>
> > >>
> > >> --
> > >>
> > >> *Gavin McDonald*
> > >> Systems Administrator
> > >> ASF Infrastructure Team
> > >>
> > >
> > >
> > > --
> > >
> > > *Gavin McDonald*
> > > Systems Administrator
> > > ASF Infrastructure Team
> > >
> >
> >
> > --
> >
> > *Gavin McDonald*
> > Systems Administrator
> > ASF Infrastructure Team
> >
>
>
> --
>
> *Gavin McDonald*
> Systems Administrator
> ASF Infrastructure Team
>
>

-- 

*Gavin McDonald*
Systems Administrator
ASF Infrastructure Team

Reply via email to