The GitHub Actions job "Flink CI (beta)" on flink.git/master has failed.
Run started by GitHub user davidradl (triggered by davidradl).

Head commit for run:
64d0316aad22e83888b65e6c3036d0a980ae33a9 / Feat Zhang <[email protected]>
[FLINK-39042][webui] Make watermark timestamps timezone-aware and configurable 
(#27552)

* [FLINK-39042][ui] Make watermark timestamps timezone-aware and configurable

* [FLINK-39042][webui] Use Intl API for timezone handling and support DST

Address review feedback:
- Use native Intl.DateTimeFormat API instead of manual offset calculation
- Replace fixed UTC offsets with IANA timezone names (e.g., America/Los_Angeles)
- IANA timezones automatically handle daylight saving time transitions
- Remove redundant console.log statements and improve code quality
- Add documentation comments with reference to IANA timezone database

* [FLINK-39042][webui] Make watermark timestamps timezone-aware and configurable

* [FLINK-39042][webui] Address code review comments

- Add MDN reference for Intl.DateTimeFormat API
- Clarify DST handling in timezone abbreviations (e.g., PST vs PDT)
- Improve error messages to explicitly mention UTC fallback
- Update comments to better explain timezone resolution logic

* Address review comments

- Remove 'pure: false' from HumanizeWatermarkToDatetimePipe as template already 
passes timezone argument
- Use Intl.supportedValuesOf('timeZone') to get all supported timezones instead 
of hardcoded list
- Keep browser local timezone as default
- Revert unnecessary changes in job-status.component.less

* fix: improve timezone fallback handling and CSS property ordering

- Enhance timezone detection fallback logic in watermark component\n- Fix CSS 
property ordering in job status component for better maintainability

* style: improve code formatting for better readability

- Split long lines in timezone options initialization for improved code 
readability

* style: optimize CSS property ordering for better maintainability

- Reorder CSS properties in job status component for improved code organization

* fix: add type assertion for Intl.supportedValuesOf to fix TS compilation error

* [FLINK-39042][webui] Use browser locale instead of hardcoded en-US in 
watermark datetime pipe

Replace hardcoded 'en-US' locale with undefined in Intl.DateTimeFormat to
respect the user's browser locale settings. This ensures the date display
order follows the user's regional preferences rather than being fixed to
the en-US format.

Suggested by @davidradl in code review.

Report URL: https://github.com/apache/flink/actions/runs/23433308460

With regards,
GitHub Actions via GitBox

Reply via email to