The GitHub Actions job "Nightly (beta)" on flink.git/master has failed.
Run started by GitHub user github-actions[bot] (triggered by 
github-actions[bot]).

Head commit for run:
69cdb54e953e0217c5cb0c42ac50f957be01211a / Ramin Gharib <[email protected]>
[FLINK-40255][table-planner] Fix compiled plan serde for VARIANT type

VARIANT plans and executes correctly, but serializing a plan containing it 
throws, so COMPILE PLAN, StatementSet#compilePlan and 
TableEnvironment#compilePlanSql are unusable with VARIANT, as is plan restore.

Two RelDataType to LogicalType converters exist and only one knew VARIANT. 
FlinkTypeFactory, used during planning, handles it. 
LogicalRelDataTypeConverter, used only by plan serde, had no VARIANT handling 
at all, so a VARIANT-typed RexNode failed with "Unsupported RelDataType: 
VARIANT" on compile and "Logical type 'VARIANT' cannot be converted to a 
RelDataType" on restore. Independently, VARIANT was missing from 
CompactSerializationChecker, so a VARIANT in an ExecNode output type fell back 
to generic serialization and failed with "Unable to serialize logical type 
'VARIANT'".

LogicalRelDataTypeConverter now converts VARIANT in both directions, and 
CompactSerializationChecker reports it as compactly serializable. The latter is 
what fixes serialization, because the compact path already round-trips VARIANT 
through LogicalTypeParser. The explicit cases added to 
LogicalTypeJsonSerializer and LogicalTypeJsonDeserializer keep the two switches 
symmetric so an externally produced plan that spells VARIANT out as an object 
still restores.

VARIANT had zero plan serde coverage. It is now exercised standalone, nested in 
collection and row types, as a RexNode type, and end to end by the new 
calc-variant restore program, whose plan carries VARIANT as the return type of 
PARSE_JSON and TRY_PARSE_JSON calls, as the type of an ITEM call on a VARIANT 
column, and in the ExecNode output type.

Report URL: https://github.com/apache/flink/actions/runs/30509852130

With regards,
GitHub Actions via GitBox

Reply via email to