The GitHub Actions job "CI" on kvrocks.git/unstable has failed. Run started by GitHub user PragmaTwice (triggered by PragmaTwice).
Head commit for run: 0bd1b081a54b6db442499c328f14cca70c503a0e / Zhixin Wen <[email protected]> fix(replication): send ack on ping even if no data written (#3220) In the old code, we only ack when there is data written and `sendReplConfAck` would only send ack if not ack was sent in the last 1 sec. This works fine for continuous traffic. However, if write stops and the last write did not trigger an ack due to 1s rate limit, no more ack would be sent. If user runs `INFO replication` on master, the user would see a replication lag that never get catch up. In this PR we send ack back whenever replication sees ping, because ping is only sent when master has no data, this should not add extra load. --------- Co-authored-by: Twice <[email protected]> Report URL: https://github.com/apache/kvrocks/actions/runs/18333804442 With regards, GitHub Actions via GitBox
