On 03/16/2010 02:50 PM, Clark Williams wrote:
>>> + except mock.exception.Error, e:
>>> + self.root_log.warning("'%s' failed." % cmd)
>>
>> It might be better to log the exception string rather than this less
>> informative warning.
>>
>
> Agreed. Maybe:
> self.root_log.warning("'%s': %s" % (cmd, e))
All the exception strings from do() already include the command text. I
was thinking simply:
self.root_log.warning(str(e))
--
buildsys mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/buildsys
