----- Original Message ----- > From: "Mike McLean" <[email protected]> > To: [email protected] > Sent: Friday, February 20, 2015 7:58:28 AM > Subject: Re: a couple minor patches > > On 02/19/2015 04:38 PM, Peter Robinson wrote: > > On Thu, Feb 19, 2015 at 8:44 PM, Mike McLean <[email protected]> wrote: > >> On 02/19/2015 03:35 PM, Peter Robinson wrote: > >>> > >>> On Thu, Feb 19, 2015 at 8:33 PM, Mike McLean <[email protected]> wrote: > >>>> > >>>> 0001 - Added a bunch of predefined archivetypes. Most of these were > >>>> added > >>>> in > >>>> our internal instance over time. Let me know if any of these look wrong. > >>>> > >>>> 0002 - just a nicer error message if a host authenticates as a non-host > >>>> user > >>> > >>> > >>> Any chance you could use git send-email or send them inline, makes > >>> them easier to read/review rather than having to load them into > >>> external viewers? > >> > >> > >> Hmm. they appear fine in Thunderbird, but I guess probably not in others. > >> I'll look into it. > >> > >> OTOH, it is much more reliable for me to consume patches that are > >> attached. > >> I've encountered numerous cases of mangling with inline patches over the > >> years > > > > "git am" tends to work quite well for that > > Yes, git am is my friend (note that it also works on downloaded > attachments from git format-patch). However, if something in the mail > pipeline has mangled the inline patch, git am can fail. Maybe it was > someone misusing the tools, but I've had lots of pains with inline patches. > > OTOH if other folks have no problems, maybe my experience is an > aberration. So, I've set up git send-email and I'll try that next time. >
I like git-send-email way, however, I'm confused about how to format the mail, either subject or body, to keep it in the original thread rather than another separate mail, when sent as a modification according to the review. BTW, why not to consider to use some code hosting service, github, bitbucket, or something else to make life easier. Regards, Chenxiong Qi > -- > buildsys mailing list > [email protected] > https://admin.fedoraproject.org/mailman/listinfo/buildsys -- buildsys mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/buildsys
