Dne 21.6.2016 v 16:49 Brian Stinson napsal(a):
> We are currently shipping mock in CentOS-Extras that includes configs for
> building against CentOS (without EPEL enabled). I think it makes sense for us
> to
> cough up these configs for inclusion upstream. I'm happy to keep an eye on
> them
> from our end if they need tweaking in the future.
Why not. But it will be nice to keep it in sync with epel-* as much as possible.
Can you check them and either improve epel-* configs too or change your
centos-* configs?
> +config_opts['chroot_setup_cmd'] = 'install bash bzip2 coreutils cpio
> diffutils centos-release elfutils findutils gawk gcc gcc-c++ grep gzip info
> intltool make patch perl python redhat-rpm-config rpm-build sed shadow-utils
> tar unzip util-linux which xz'
Centos does not have groups? Can there be group instead of list? What about
buildsys-macros?
> +config_opts['macros']['%centos_ver'] = "5"
> +config_opts['macros']['%rhel'] = "5"
> +config_opts['macros']['%el5'] = "1"
> +config_opts['macros']['%redhat'] = "5"
> +config_opts['macros']['%_vendor'] = "redhat"
> +config_opts['macros']['%_vendor_host'] = "redhat"
> +config_opts['macros']['%_host'] = "i386-redhat-linux-gnu"
You are missing
config_opts['macros']['%__arch_install_post'] = '%{nil}'
See commit c38fff2478e5a04ae29f38ae0444d68269751aca.
> +# no ccache in base repo
> +config_opts['plugin_conf']['ccache_enable'] = False
> +config_opts['plugin_conf']['yum_cache_enable'] = False
This should not be in chroot config. This should be builder decision and should
go to site-defaults.cfg or
~/.config/mock.cfg
> +config_opts['yum.conf'] = """
> +[main]
> +cachedir=/var/cache/yum
> +keepcache=1
> +debuglevel=2
> +reposdir=/dev/null
> +logfile=/var/log/yum.log
> +retries=20
> +obsoletes=1
> +gpgcheck=0
> +assumeyes=1
> +syslog_ident=mock
> +syslog_device=
Any reason why
mdpolicy=group:primary
is missing?
> +exclude=*.x86_64
Why this?
> +[base]
> +name=centos 5 i386 - base
> +baseurl=http://mirror.centos.org/centos/5/os/i386/
Can you use metalink or mirrolist? Metalink is prefered, but I think epel5
cannot handle it.
> +enabled=1
> +gpgcheck=0
Any reason why gpgcheck is disabled?
> +cost=2000
Why so big cost on base repo? IMO base repo should not have cost at all.
--
Miroslav Suchy, RHCA
Red Hat, Senior Software Engineer, #brno, #devexp, #fedora-buildsys
--
buildsys mailing list
[email protected]
https://lists.fedoraproject.org/admin/lists/[email protected]
