Matteo, All, On Friday 25 May 2007 18:57, Matteo Croce wrote: > OpenWrt devs decided to thrash the 2.4 AR7 port and keep only the 2.6,
Good! > so in the BusyBox options i removed the 2.2 and 2.4 old module support > and the result is that at boot time no module were loaded. > I investigated a bit and I noticed that OpenWrt 's scripts calls insmod > without > a full path, like "insmod tiatm" since BusyBox's insmod scan the whole > /lib/modules to find the right module. The right solution here would be to fix the OpenWRT init scripts. Did you try to file in a bug there? They might not be aware of the issue either and might be interested as well to at least know there is an issue. > Then I discovered that the code that scans /lib/modules is enabled only in > 2.4 aware configs, so i've made the attached patch to fix it, but in an ugly > way. Ha! You say yourself it's ugly! Hehehe ;-) Just pulling your leg! > Yann E. MORIN wrote: > > First of, we must decide wether its the job of insmod or not. Again, plain > > insmod from module-init-tools does NOT search for modules. Do we want to add > > this feature that the original code doesn't have? I guess no. Guys, what's your opinions? Include such support or not? > > Second, you're mostly duplicating code in your patch. Common code should > > lie > > in a function that gets called from everywhere it's needed. If we decide to > > incorporate this code, you'll have to refactor your patch. > I know that plain insmod from module-init-tools does NOT search for modules, > but if it is not insmod jobwhy we do it in the 2.4 version? I guess historical reasons. Trend is to migrate as much as possible to 2.6 support, and only keep 2.4 to what is there (and fix only gross bugs). > On the other hand I agree with Yann that putting the common code in a function > is the right way, even if I don't really duplicate code, it gets compiled once > due to some #ifdef (ugly too, i have to admit) You're duplicating code when both 2.4 _and_ 2.6 are configured. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +0/33 662376056 | Software Designer | \ / CAMPAIGN | ^ | | --==< °_° >==-- °------------.-------: X AGAINST | /e\ There is no | | http://ymorin.is-a-geek.org/ | (*_*) | / \ HTML MAIL | """ conspiracy. | °------------------------------°-------°------------------°--------------------° _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
