On Sat, Jun 23, 2007 at 01:31:19PM -0400, Mike Frysinger wrote:
>On Saturday 23 June 2007, Mike Frysinger wrote:
>> +int xioctl(int fd, int request, unsigned long arg)
>> +{
>> + int ret = ioctl(fd, request, arg);
>> + if (ret != 0)
>> + bb_perror_msg_and_die("ioctl");
>> + return ret;
>> +}
>
>actually now that i think about it, considering the usage here (people usually
>only care if it fails, they dont want to read the return value), we probably
>can do:
>void xioctl(...)
Sounds ok to me. I had a patch which did this but did not apply it (and
forgot to ask..) since i though that discarding the information about
which ioctl it was that failed would not be well received, back then.
Let's hear what vda says, i'd say fore! :)
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
