On Friday 21 September 2007 15:53, Bernhard Fischer wrote:
> On Fri, Sep 21, 2007 at 06:43:29AM -0700, [EMAIL PROTECTED] wrote:
> >Author: vda
> >Date: 2007-09-21 06:43:28 -0700 (Fri, 21 Sep 2007)
> >New Revision: 19927
> >
> >Log:
> >microcom: new applet by Vladimir Dronnikov <[EMAIL PROTECTED]>
> >
> >
> >
> >Modified:
> >   trunk/busybox/include/applets.h
> >   trunk/busybox/include/usage.h
> >   trunk/busybox/util-linux/Config.in
> >   trunk/busybox/util-linux/Kbuild
> 
> vda.
> 
> Fortunately you forgot to add the actual microcom.c
> 
> Several grave issues with the submitted version:
> 1) no copyright nor a license!

Vladimir, please send us a verbatim

/*
 * Header comment block which describes your (c) and licencing terms
 */

> 2) it is not related to the util-linux package, thus should live
> somewhere else. I'd put it into network/, but miscutils would also be
> fine.
> 3) other cosmetic issues i raised in the corresponding thread.

I will move it to miscutils (in separate commit).

Sorry.
--
vda
_______________________________________________
busybox mailing list
busybox@busybox.net
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to