On Saturday 09 February 2008 15:29, [EMAIL PROTECTED] wrote:
> Hello!
> 
> This is new sendmail update.
> Sendmail is shrunk.
> Fetchmail is rewritten.
> It now supports postprocessing of fetched mail files.

People typically send patches, not whole updated files.
In patch form, you'd avoid hitting this collision with
other changes:

-       bb_signals_recursive(0
-                       + (1 << SIGCHLD)
-                       + (1 << SIGALRM)
-                       , signal_handler);
+       sig_catch(SIGCHLD, signal_handler);
+       sig_catch(SIGALRM, signal_handler);

There are no sig_catch anymore!


        while ((answer = xmalloc_getline(stdin)) && '-' == answer[3])
                continue;

And if we read only 0, 1 or 2 bytes? answer[3] will be past end of line...



static const char *xargs[] = {
        "openssl", "s_client", "-quiet", "-connect", NULL, "-tls1", 
"-starttls", "smtp", NULL
};

Hmm. These arrays are modifiable, right? Result:

# size */sendmail.o
   text    data     bss     dec     hex filename
   3001      48       8    3057     bf1 networking/sendmail.o

Please do the "struct globals" trick and get data == bss == 0 bytes.

Please find lightly edited sendmail.c (as a file and as a patch)
attached.
--
vda

Attachment: 6.patch.bz2
Description: BZip2 compressed data

Attachment: sendmail.c.bz2
Description: BZip2 compressed data

_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to