On Tue, Mar 18, 2008 at 7:15 AM, Denys Vlasenko
<[EMAIL PROTECTED]> wrote:
>  > Is there anything left to be converted? Perhaps I will be able to
>  > contribute something. For instance, from your link it looks like
>  > ifupdown is not converted yet.
>
>  Well, yea, that one needs fixing.

Looks like fixing ifupdown is pretty much simple. Please
take a look at the attached patch.

Regards,
Aleksey
---
 networking/ifupdown.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Index: busybox-1.9.1/networking/ifupdown.c
===================================================================
--- busybox-1.9.1.orig/networking/ifupdown.c
+++ busybox-1.9.1/networking/ifupdown.c
@@ -936,13 +936,13 @@ static int doit(char *str)
 		int status;
 
 		fflush(NULL);
-		child = fork();
+		child = vfork();
 		switch (child) {
 		case -1: /* failure */
 			return 0;
 		case 0: /* child */
 			execle(DEFAULT_SHELL, DEFAULT_SHELL, "-c", str, NULL, my_environ);
-			exit(127);
+			_exit(127);
 		}
 		waitpid(child, &status, 0);
 		if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) {
@@ -1022,7 +1022,7 @@ static int popen2(FILE **in, FILE **out,
 	}
 
 	fflush(NULL);
-	switch (pid = fork()) {
+	switch (pid = vfork()) {
 	case -1:			/* failure */
 		close(infd[0]);
 		close(infd[1]);
@@ -1037,7 +1037,7 @@ static int popen2(FILE **in, FILE **out,
 		close(outfd[0]);
 		close(outfd[1]);
 		BB_EXECVP(command, argv);
-		exit(127);
+		_exit(127);
 	default:			/* parent */
 		*in = fdopen(infd[1], "w");
 		*out = fdopen(outfd[0], "r");
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to