On Tuesday 18 March 2008, Tito wrote:
> this patch adds the new function xcheck_name()

as long as this is optional, it sounds great

> void xcheck_name(const char *name)
> {
>       int i = 0;
>
>       do {
>               if (!isalnum(*name)
>                && !(*name == '_')
>                && !(*name == '.')
>                && !(*name == '@')
>                && !(*name == '-' && i)
>                && !(*name == '$' && !*(name + 1))
>               )

i'd combine the inversion so it'll be easier to understand.  so like:
if (!( ....... ))

the list of valid characters also doesnt match the common shadow package.  the 
regex to validate against is:
[a-z_][a-z0-9_-.]*[$]
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to