Hello! + Added 3 options to TFTP: -v be verbose -- it used to be uncontrollably _way_ verbose when compiled with DEBUG feature. -n N set retry counter -- it used to be hardcoded arbitrary value. -t MS set timeout -- it used to be pure arbitrary value which caused failures even while using loopback network!
- Getting files from current TFTPD is broken. Moreover, the simpler are tftp[d]_main() the more complex (and bloaty) is tftp_protocol(). My version is smaller and IMO clearer: personally I lost the path of the flow of control in tftp_protocol(). And why all these recvmsg()s when it is updsvd who is responsible for providing plain stdin/out. TFTPD is a simple filter implementing a protocol, not UDP-aware particular network utility! Next. IMO, access should be controlled by system means: updsvd can set effective user -- its rights should be used when granting (or not) access to files. Generic test on "world read/writeness" is way simple but dumb (or too rough). Let us create a specific user and we are done. Please, do consider applying! -- Vladimir
tftpd.patch
Description: Binary data
_______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
