On Wednesday 26 March 2008 14:58, Bernhard Fischer wrote:
> > USE_FBSET(APPLET(fbset, _BB_DIR_USR_SBIN, _BB_SUID_NEVER))
> >+USE_FBSPLASH(APPLET(fbsplash, _BB_DIR_BIN, _BB_SUID_NEVER))
>
> Perhaps it would make more sense to put this into /sbin ?
Have no idea, my /sbin is a symlink to /bin...
Does it matter?
> > USE_FDFLUSH(APPLET_ODDNAME(fdflush, freeramdisk, _BB_DIR_BIN,
> > _BB_SUID_NEVER, fdflush))
> > USE_FDFORMAT(APPLET(fdformat, _BB_DIR_USR_BIN, _BB_SUID_NEVER))
> > USE_FDISK(APPLET(fdisk, _BB_DIR_SBIN, _BB_SUID_NEVER))
>
> >diff -d -urpN busybox.0/libbb/lineedit.c busybox.1/libbb/lineedit.c
> >--- busybox.0/libbb/lineedit.c 2008-03-24 15:42:06.000000000 +0100
> >+++ busybox.1/libbb/lineedit.c 2008-03-26 12:12:04.000000000 +0100
> []
> Denis, this is unrelated, please apply separately.
Sorry. I discovered this bug while testing fbsplash - ash on R/O mounts
was losing history immediately. You are right. Need stop mixing things up.
> >diff -d -urpN busybox.0/miscutils/fbsplash.c busybox.1/miscutils/fbsplash.c
> >--- busybox.0/miscutils/fbsplash.c 1970-01-01 01:00:00.000000000 +0100
> >+++ busybox.1/miscutils/fbsplash.c 2008-03-26 14:08:04.000000000 +0100
> >@@ -0,0 +1,446 @@
> >+/* vi: set sw=4 ts=4: */
> >+/*
> >+ * splash implementation for busybox
>
> s/splash/bootsplash/
There is nothing "splashy" or "booty" in this program per se,
it's just image display utility with optional progress bar...
don't know how to call it. Hmm. I will delete this line.
> >+ *
> >+ * Copyright (C) 2008 Michele Sanges <[EMAIL PROTECTED]>,
> >+ * <[EMAIL PROTECTED]>
> >+ *
> >+ * Licensed under GPLv2 or later, see file LICENSE in this tarball for
> >details.
> >+ *
> >+ * Usage:
> >+ * - use kernel option 'vga=xxx' or otherwise enable framebuffer device.
> >+ * - put somewhere the fbsplash.ini file and image in .ppm format.
>
> s/\.ini/\.cfg/;# We're not on windows, we have configuration files
>
> []
> As said previously, it may be benefical to pass a pointer to struct
> geometry to the drawing functions instead of passing x/y and eventually
> r/g/b/a as individual parameters.
>
> >diff -d -urpN busybox.0/miscutils/fbsplash.ini
> >busybox.1/miscutils/fbsplash.ini
> >--- busybox.0/miscutils/fbsplash.ini 1970-01-01 01:00:00.000000000 +0100
> >+++ busybox.1/miscutils/fbsplash.ini 2008-03-26 14:06:45.000000000 +0100
>
> Please rename to .cfg
Well, actually applet does not care whether it's .ini or .cfg,
user has to specify the full name ("fbsplash -i <file>")
and there is no default (!"defailts to xxx.ini").
Will rename in svn.
--
vda
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
