On Thu, Apr 10, 2008 at 09:57:35PM +0200, Denys Vlasenko wrote: >On Thursday 10 April 2008 17:39, Bernhard Fischer wrote: >> Hi, >> >> make check seems to be broken: > >Yes indeed... Try this patch. >-- >vda
>diff -d -urpN busybox.7/Makefile busybox.8/Makefile >--- busybox.7/Makefile 2008-04-06 07:33:55.000000000 +0200 >+++ busybox.8/Makefile 2008-04-10 21:55:43.000000000 +0200 >@@ -361,7 +361,8 @@ endif > # of make so .config is not included in this case either (for *config). > > no-dot-config-targets := clean mrproper distclean \ >- cscope TAGS tags help %docs check% >+ cscope TAGS tags help %docs >+#bbox# check% is removed from above > > config-targets := 0 > mixed-targets := 0 >diff -d -urpN busybox.7/Makefile.custom busybox.8/Makefile.custom >--- busybox.7/Makefile.custom 2008-04-06 07:33:55.000000000 +0200 >+++ busybox.8/Makefile.custom 2008-04-10 21:55:43.000000000 +0200 >@@ -46,9 +46,13 @@ ifneq ($(strip $(DO_INSTALL_LIBS)),n) > done > endif > >+# Not very elegant: copies testsuite to objdir... >+.PHONY: check >+.PHONY: test > check test: busybox busybox.links >- bindir=$(objtree) srcdir=$(srctree)/testsuite SED="$(SED)" \ >- $(SHELL) $(srctree)/testsuite/runtest $(if $(KBUILD_VERBOSE:0=),-v) >+ test -d $(objtree)/testsuite || cp -a $(srctree)/testsuite $(objtree) cp -a is not portable (IIRC -dpf was) >+ bindir=$(objtree) srcdir=$(srctree)/testsuite \ >+ $(SHELL) -c "cd $(objtree)/testsuite && $(srctree)/testsuite/runtest >$(if $(KBUILD_VERBOSE:0=),-v)" You dropped passing down SED so broke running the testsuite on OS that doesn't have a working system-provided sed :( > > .PHONY: release > release: distclean _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
