On Saturday 31 May 2008 22:01, Cristian Ionescu-Idbohrn wrote:
> On Sat, 31 May 2008, Denys Vlasenko wrote:
>
> > On Saturday 31 May 2008 19:10, Cristian Ionescu-Idbohrn wrote:
> > >
> > > Hmm... I must be blind :( Can't see it :( What's wrong? Compare to this
> > > (some lines above in include/applets.h):
> > >
> > > USE_DIRNAME(APPLET_NOFORK(dirname, dirname, _BB_DIR_USR_BIN,
> > > _BB_SUID_NEVER, dirname))
> >
> > I meant that if you made it NOFORK (chunk #1) then you must not exit
> > (chunk #2).
> > Chunk #1 is ok if you fixed chunk #2.
>
> Got it now. Let's see. Is this a better patch?
# ./busybox ash
/.1/usr/srcdevel/bbox/fix/busybox.t8 # printf '\c' foo
Segmentation fault
Other than that: use spaces here, otherwise indentation of "printf"
breaks for anybody with non-4-char-wide tabs:
{ BUILTIN_REGULAR "printf", printfcmd },
Do not replace "return EXIT_SUCCESS;" with "return 0;" - some people
insist on having symbolic constant there (don't know why it's
so important, but why not?)
--
vda
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
