>>>>> "Denys" == Denys Vlasenko <[EMAIL PROTECTED]> writes:

[resend with proper from:]

Hi,

 >> if (strcmp(p, request) == 0) {
 >> set_remoteuser_var:
 >> -                           remoteuser = xstrndup(request, u - request);
 >> +                           remoteuser = xstrndup(request, strchr(request, 
 >> ':') - request);

 Denys> Here where request without ':' will bite us.

Actually, thinking about it a bit more - This cannot happen as the
strcmp() wouldn't match. Notice that we could use 'p' here instead of
'request' and the result would be the same.

-- 
Bye, Peter Korsgaard
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to