On Saturday 12 July 2008 05:36:05 Denys Vlasenko wrote:
> BTW: there is a speedup opportunity in mdev -s: we parse config file
> repeatedly (which includes compiling regexp) for each device scanned!

Which is generally a cache local activity, probably not even as expensive as a 
system call (although I admit I haven't benched it with that in mind and it 
could vary by platform).  I do know that back when I _did_ bench it for 
overall performance, it did quite well.

The alternative is keeping the config file and all its compiled regexes in 
memory with a more complicated data structure.  (Admittedly platforms that 
want a large config file are unlikely to be memory constrained, but still.)

> Volunteers to fix that?

I have a tropism for _simple_.  This entire discussion seems to me to be about 
how to complicate mdev for questionable gains.

I guess I still have toybox. :)

Rob
-- 
"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox

Reply via email to