On Sun, Jul 27, 2008 at 02:07:29PM +0200, Denys Vlasenko wrote:
>
> See attached patch where these (and some more) are fixed.
>
That looks great to me. Only question is about the following section:
> #define PROGNAME_WIDTH 20
> #define PROGNAME_WIDTH_STR "20"
> /* PROGNAME_WIDTH chars: 12345678901234567890 */
> #define PROGNAME_BANNER "PID/Program name "
>
> struct prg_node {
> struct prg_node *next;
> long inode;
> char name[PROGNAME_WIDTH];
> };
>
> #define PRG_HASH_SIZE 211
Don't you want to wrap it in #if ENABLE_FEATURE_NETSTAT_PRG ? I don't
think the compiler would care either way, but everything else -p
related is wrapped like that... :)
Otherwise, if you'd apply it, I'd be very happy :)
Thanks,
Gabriel
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
