Hi Timo, I took a look at your patch. Wow, this is big :)
On Thursday 04 September 2008 18:01, Vladimir Dronnikov wrote: > I wish the patch were applied. It is much better to work on some base > code than ping-pong a huge patches... Vanilla BB modprobe should be > gone as it is big, slow and lacks several features. > > Tested the patch. Compiles cleanly with some cleanup in modutils.h > (several defines are redundant). Works. Vladimir & Timo, can you ping-pong these small fixes between you two (CC list) and when you are happy with them, indicate which patch is "final" when you send it to the ml. >From my side, I only want "small" modprobe to be retained. In other words, I don't want this to happen: USE_DELGROUP(APPLET_ODDNAME(delgroup, deluser, _BB_DIR_BIN, _BB_SUID_NEVER, delgroup)) USE_DELUSER(APPLET(deluser, _BB_DIR_BIN, _BB_SUID_NEVER)) USE_DEPMOD(APPLET(depmod, _BB_DIR_SBIN, _BB_SUID_NEVER)) -USE_MODPROBE_SMALL(APPLET_ODDNAME(depmod, modprobe, _BB_DIR_SBIN, _BB_SUID_NEVER, modprobe)) USE_DEVFSD(APPLET(devfsd, _BB_DIR_SBIN, _BB_SUID_NEVER)) USE_DF(APPLET(df, _BB_DIR_BIN, _BB_SUID_NEVER)) USE_APP_DHCPRELAY(APPLET(dhcprelay, _BB_DIR_USR_SBIN, _BB_SUID_NEVER)) When you send "final" patch. please spend 10 more minutes and write a bullet list of things fixed/improved as compared to current implementation. Thanks! -- vda _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
