On Saturday 13 September 2008 22:09, [EMAIL PROTECTED] wrote:
> The replacement to modprobe-small.
> I explained the changes in "modprobe patches" mailing list thread an hour ago.
> "speeds" contains profiling info for the 3 flavors: fast, small and Timo s.
> A typical speedup is of up to 10 times.
>
> Please, comment and consider applying.
Looks like a bug:
+ char *s = ptr + strlen(ptr) + 1;
+ s = ptr + strlen(ptr) + 1;
Please use opts = getopt32(...), it's usually smaller to use local
variable (gcc can cache it in register) than global one:
+ getopt32(argv, "qvrab"); // TODO: -b -- blacklist module by name!
+ // assume -q if not -v
+ if (!(option_mask32 & OPT_v))
+ option_mask32 |= OPT_q;
+ argv += optind;
+
+ /* If not rmmod, parse possible module options given on command line.
+ * modprobe takes one module name, the rest are parameters unless -a
specified. */
+#if ENABLE_FEATURE_MODUTILS_FAST_OPTIONS_ON_CMDLINE
+ if (!(option_mask32 & OPT_r) && !(option_mask32 & OPT_a)) {
!(option_mask32 & (OPT_r+OPT_a))
+ options = parse_cmdline_module_options(argv);
+ argv[1] = NULL;
+ }
+#endif
--
vda
_______________________________________________
busybox mailing list
[email protected]
http://busybox.net/cgi-bin/mailman/listinfo/busybox
