Denys Vlasenko schrieb: > On Sunday 21 September 2008 16:11, Seonghun Lim wrote: >> Hi, >> >> route applet fails to add/delete a route on 64-bit BE machines with >> following message: >> >> bogus netmask 255.255.255.0 >> >> The netmask sanity check routine in INET_setroute() stores the value in >> an unsigned long variable, whose size is not always 32 bit. Then it is >> inverted to yield a value with first 32 bits set to 1. So the testing >> condition-- if (mask & (mask + 1)) --is never satisfied, except for >> "0.0.0.0". >> >> There're some more routines that use unsigned long to store IPv4 >> addresses, but they seem to make no problem, so skipped :-) > > Applied, thanks. will be in 1.13.0 > --
NTL i would call to fix them, some rearrangement of code may expose them also. jus my 2 cents, re, wh _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
