> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > On Behalf Of Denys Vlasenko > Sent: den 29 oktober 2008 02:03 > To: [email protected] > Subject: Re: [patch] scripts/Makefile.lib > > On Tuesday 28 October 2008 20:58, Cristian Ionescu-Idbohrn wrote: > > Would this patch be acceptable? > > > > Convert from '-Wl,-<option>' (used to give specific gcc link options) > > to direct link '-<option>'. > > > > Index: scripts/Makefile.lib > > =================================================================== > > --- scripts/Makefile.lib (revision 22830) > > +++ scripts/Makefile.lib (working copy) > > @@ -118,7 +118,7 @@ > > cpp_flags = -Wp,-MD,$(depfile) $(NOSTDINC_FLAGS) $(__cpp_flags) > > > > # TODO: seems to be a wrong thing to do! LDFLAGS contains gcc's flags! > > -ld_flags = $(LDFLAGS) $(EXTRA_LDFLAGS) > > +ld_flags = $(filter-out -Wl$(comma)%,$(LDFLAGS) $(EXTRA_LDFLAGS)) > > > > # Finds the multi-part object the current object will be linked into > > modname-multi = $(sort $(foreach m,$(multi-used),\ > > > What case does it fix? > -- > vda
It fixes the fact that $(LD_FLAGS) may contain linker directives specified as -Wl,<ld option>, which are intended to be passed through gcc. However, $(ld_flags) is used with ld and it wants its options without the -Wl, prefix. The TODO comment above should at the same time be replaced with something like: # Remove the -Wl, prefix from linker options normally passed through gcc //Peter _______________________________________________ busybox mailing list [email protected] http://busybox.net/cgi-bin/mailman/listinfo/busybox
