Hi,

During busybox 1.13.4 testing, I have observed that the 
"testsuite/tar/tar_with_link_with_size" test fails.
Test Result: "FAIL: tar_with_link_with_size"

I have analyzed this failure and found that this is due to the mismatch between 
expected and the actual output:
expected output:
"
res1="\
lrwxrwxrwx user/group 0 2008-07-19 15:02:37 
firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
-rwxr-xr-x user/group 512 2008-07-19 15:02:37 
firmware-372/sources/native/bin/qemu-setup.sh"
"

actual output(currently running as root):
"
res1="\
lrwxrwxrwx 0/0         0 2008-07-19 15:02:37 
firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
-rwxr-xr-x 0/0       512 2008-07-19 15:02:37 
firmware-372/sources/native/bin/qemu-setup.sh"
"

Based on this observation, I have generalized the expected output and created a 
patch for this test case. After applying the below listed patch, this test 
passes.
Test Result: "PASS: tar_with_link_with_size"

Please let me know your opinion on this patch.

----------------------------
--- /tmp/tar/tar_with_link_with_size    2008-11-09 17:28:19.000000000 +0000
+++ tar/tar_with_link_with_size 2009-05-28 08:03:30.000000000 +0000
@@ -19,9 +19,11 @@
     $ECHO -ne 
"\x90\xc3\x82\x29\xe8\x8c\xb8\x95\x83\x32\x40\x61\x11\x11\xd3\xaa"
     $ECHO -ne "\x3f\x8b\xb9\x22\x9c\x28\x48\x0a\x22\x71\xee\x80"
 }

+user=`id -u`
+group=`id -g`
 res1="\
-lrwxrwxrwx user/group         0 2008-07-19 15:02:37 
firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
--rwxr-xr-x user/group       512 2008-07-19 15:02:37 
firmware-372/sources/native/bin/qemu-setup.sh"
+lrwxrwxrwx $user/$group         0 2008-07-19 15:02:37 
firmware-372/sources/native/bin/chroot-setup.sh -> qemu-setup.sh
+-rwxr-xr-x $user/$group       512 2008-07-19 15:02:37 
firmware-372/sources/native/bin/qemu-setup.sh"
 export TZ=UTC-2
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to