On Sat, Jun 6, 2009 at 10:17 PM, Gilles Espinasse<[email protected]> wrote: > The most obvious problem was 'module not found' returning status 0 > > Add fixes for some existing cornercases > modprobe -r an existing module or alias not loaded should return 0 > modprobe alias already loaded should return 0 > > All that has been tested mainly with dummy.ko.gz module and rtnl-link-dummy > alias > > Fix an old comment s/modprobe.dep/modules.dep/ > > modprobe actually does not support -k autoclean (should we really?) > Could not modprobe -r (without parameter) specific code be removed? > Actually, it just give modprobe:rmmod: Bad address (even with rmmod applet > enabled) > > function old new delta > modprobe_main 463 533 +70 > do_modprobe 266 277 +11 > add_probe 81 80 -1 > ------------------------------------------------------------------------------ > (add/remove: 0/0 grow/shrink: 2/1 up/down: 81/-1) Total: 80 bytes > text data bss dec hex filename > 221388 1585 8752 231725 3892d busybox_old > 221468 1585 8752 231805 3897d busybox_unstripped > > Signed-off-by: Gilles Espinasse <[email protected]>
Sorry, there were changes to modprobe recently, and now patch doe s not apply. Can you rediff it please? > - /* bool. "Did we have 'symbol:FOO' requested on cmdline?" */ > - smallint need_symbols; > + /* 1 "Did we have 'symbol:FOO' requested on cmdline?" > + * 2 modprobe status */ > + smallint modprobe_flags; Try using two separate variables. It may turn out to result in smaller code. Thanks! -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
