On Fri, Jun 19, 2009 at 2:09 AM, Colin Watson<[email protected]> wrote: > When FEATURE_MOUNT_HELPERS is enabled, mount should support the -i > option, which prevents calling the helper function. This is used by > FUSE: it installs fusermount as a helper, and if it's configured to > update /etc/mtab then it does so by calling 'mount -i -f' (i.e. don't > call helper, fake the system call, but do update mtab). I believe this > is a fairly standard thing for mount helpers to want to do (why should > they include code to update mtab when mount can do it for them?) and so > I think it's worth supporting by default when mount helpers are enabled. > > mount also ought to pass through the -f and -n options to helpers as > necessary, since they may reasonably want to attempt to handle them. > util-linux mount does this. > > Zero bloatcheck impact with defconfig. With FEATURE_MOUNT_HELPERS > additionally enabled: > > function old new delta > mount_it_now 293 332 +39 > packed_usage 25845 25863 +18 > .rodata 125771 125789 +18 > ------------------------------------------------------------------------------ > (add/remove: 0/0 grow/shrink: 3/0 up/down: 75/0) Total: 75 bytes > > Signed-off-by: Colin Watson <[email protected]>
Applied, thanks. -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
