----- Original Message -----
From: "Denys Vlasenko" <[email protected]>
To: <[email protected]>
Cc: "Gilles Espinasse" <[email protected]>
Sent: Sunday, July 05, 2009 3:43 AM
Subject: Re: [PATCH] Shorten some DBG messages
> On Thursday 18 June 2009 17:06, Gilles Espinasse wrote:
> > Function name is already displayed and allow to differenciate all skip
... messages
> > With shorter message and function name, and using relative path for
kernel modules,
> > 80% of debug messages may need only one line.
> > That's far easier to read and messages disappear slower on screen.
>
> > - DBG("skipping %s, it is already loaded", name);
> > + DBG("skip %s : already loaded", name);
>
> I do not understand what changes here.
>
message is shorter and appear in one line with 80 column most of the time.
this all depend on the module name, path and kernel version length.
> > -static void load_modules_dep(void)
> > +static void load_mod_dep(void)
>
> IMO name got worse, not better. modules_dep here
> refers to file NAME: modules.dep. mod_dep breaks that.
>
not important, this was just to spare 4 characters in line lenght on the
message as function name appear in the printed log line.
Gilles
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
