How is the MS_BIND stuff a good idea?  Duplicating a long #ifdef staircase in 
two places doesn't really sound like an improvement.  Besides, all these 
#defines are already in a standard header file if you're building on a system 
that can actually use the result.  (If they're not in your header, that means 
the kernel headers you're using don't know about that call, and thus you 
probably shouldn't be using it.)

What might be better is some kind of switch you can throw to trim this 
functionality when it's not supported, to avoid a build break.  Either a 
CONFIG option for "2.6 mount options", or a single "#ifndef MS_RELATIME" to 
disable the lot of it, checking the most recent one.  (There's not much point 
in adding extra granularity, special support for a 2.6.12 kernel as distinct 
from a 2.4 kernel doesn't really seem worth the effort to me.)

Am I missing something?

Rob
-- 
Latency is more important than throughput. It's that simple. - Linus Torvalds
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to