On Wed, Aug 12, 2009 at 3:56 PM, Michal Simek<[email protected]> wrote:
>>>  test -x hush || {
>>> -       echo "No ./hush - creating a link to ../../busybox"
>>> -       ln -s ../../busybox hush
>>> +       BUSYBOX=`which busybox`
>>> +       if test -n "$BUSYBOX" ; then
>>> +               echo "No ./hush - creating a link to $BUSYBOX"
>>> +               ln -s $BUSYBOX hush
>>> +       else
>>> +               echo "Busybox/Hush shell not exist"
>>> +               exit 1
>>> +       fi
>>>  }
>>
>> This will make it harder to run testsuite
>> from inside freshly built tree: the above code
>> will pick up installed hush instead, right?
>
> Maybe worth do do just checking that ../../busybox exists and if not just
> write any message and ends.

Yes, this is simple. Please review attached patch.


>>> +eval $(sed -e '/^#/d' -e '/^$/d' -e 's:^:export :' .config)
>>> +
>>> +PWD=`pwd`
>>> +
>>>  PATH="$PWD:$PATH" # for hush and recho/zecho/printenv
>>>  export PATH
>>
>> This is ok, I will apply it - see attached patch.
>
> I am trying to run ltp on hush and runltp use PWD too. It will be better if 
> hush
> will export PWD variable. I am not script specialist and don't have any 
> statistic but seems to me it
> is common thing and shell should provide it. What do you think?

hush currently has no support for special variables at all
(not counting $1, $_ etc). It makes sense to add it,
but it will take some time.
-- 
vda

Attachment: 9.patch
Description: Binary data

_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to