On Sat, Aug 22, 2009 at 03:46:41PM +0200, Denys Vlasenko wrote:
>On Friday 21 August 2009 11:21, Bernhard Reutner-Fischer wrote:
>> On Wed, Aug 19, 2009 at 11:46:26PM +0200, Bernhard Reutner-Fischer wrote:
>> >On Wed, Aug 19, 2009 at 12:12:17PM -0700, Nathan Angelacos wrote:
>> 
>> updated full patch is attached (which also handles 'beep -d' like it
>> should)
>
>Is there some quirk in command line format which prevents usage
>of getopt()?

hm, no. Just getopt32 didn't work out for that applet.
It would be nice if we could somehow make getopt32 return a vector of
{int;void*} in the order of options that were specified, perhaps?
>
>                while (rep) {
>                        ioctl_arg = (int)(CLOCK_TICK_RATE/freq);
>                        xioctl(speaker, KIOCSOUND, (void*)ioctl_arg);
>                        usleep(1000 * length);
>                        ioctl(speaker, KIOCSOUND, 0);
>                        if (rep--)
>                                usleep(delay);
>                }
>
>"if (rep--)" is always true. did you mean "if (--rep)"?
right.
>
>I propose the following two patches.

Looks ok to me, Nathan, can you test this please?

thanks!
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox

Reply via email to