On Tuesday 22 September 2009 17:28, Matthew Stoltenberg wrote: > I'm currently building 1.14.3 just fine with gcc-3.4.3 (pentium3 > target). However, when I tried updating to 1.15.1, I'm getting this > error: > > miscutils/hdparm.c: In function `dev_size_mb': > miscutils/hdparm.c:1355: error: `BLKGETSIZE64' undeclared (first use > in this function) > > And: > util-linux/fdisk.c: In function `bb_BLKGETSIZE_sectors': > util-linux/fdisk.c:372: error: `BLKGETSIZE64' undeclared (first use in > this function) > > It looks like someone removed that macro. > > diff busybox-1.14.3/include/platform.h busybox-1.15.1/include/platform.h > <...snip...> > < #if !defined(BLKGETSIZE64) > < #define BLKGETSIZE64 _IOR(0x12,114,size_t) > < #endif > > I'm curious as to the reason for that. I can put a patch together to > fix it. I see a couple of ways to do it: > 1. Add the macro back with notes to prevent future regressions > 2. Add the macro back with a new config option (not sure where it > would go in the KBuild though...)
I just do not want platform.h to keep this kind of Linux-specific, special ioctl defines. It has a potential to clog it up. How about this: http://busybox.net/downloads/fixes-1.15.1/busybox-1.15.1-buildsys.patch Does this look ok to you? -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
