On Wednesday 07 October 2009 11:19, Magnus Damm wrote: > > I do not understand what this patch tries to achieve. > > Please describe the reason for these changes. > > Sorry for the unclear code. This patch adds support for using the > "tsize" option in the busybox client. Without this patch only the tftp > server case includes "tsize" support.
Understood. > >> 3: busybox-git-tftp-progress-20090930.patch > > > > +/* SIGALRM logic nicked from the wget applet */ > > +static void progress_meter(int flag) > > > > You duplicate the code this way. > > It makes more sense to move SIGALRM code to libbb/progress.c > > in previous patch, and just call it from wget. > > I'd like to share as much code as possible but the signal handling > code is accessing global variables specific to each applet. So I > decided to only put reentrant code in libbb. I believe that letting > libbb access globals may lead to very messy code. Or do you have any > good suggestions how to break it out in a cleaner way? Aha... then it's ok. -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
