Denys Vlasenko wrote:
On Tuesday 02 March 2010 13:45, Timo Teräs wrote:
If one gets POLLHUP, it's now never handled in the httpd code, and poll will
keep returning it all the time.
We really need to close fd when we get POLLERR or POLLHUP. Previously it lead
to read() or write() which would
indicate error and lead to clean up. Now those are just ignored.
Like this?
http://busybox.net/downloads/fixes-1.16.0/busybox-1.16.0-POLLHUP.patch
Yes. If you do want to check for explicit return events, it's probably enough
to check for POLLIN|POLLERR|POLLHUP where read() is done, and POLLOUT when
write() is done. Traditional select() logic returns POLLHUP in readfds.
However, checking for extra events does not harm.
Thanks,
Timo
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
