On Man, Mar 22, 2010 at 06:25:49 +0100, Denys Vlasenko wrote:
> On Mon, Mar 22, 2010 at 3:09 PM, Alexander Shishkin <[email protected]>
> wrote:
> > + } else
> > + /* month_name d HH:MM:SS
>
> YYYY
>
> > + * this is supported by the GNU make */
>
> perhaps GNU *date*?
See, I wasn't joking about monday.
>
> > + if (isalpha(date_str[0])) {
>
> Why do you want to check that? in some locales it may fail...
First thing that came to mind.
>
> > + char *res = strptime(date_str, "%b %d %T %Y", ptm);
> > + if (!res || *res)
> > + bb_error_msg_and_die(bb_msg_invalid_date,
> > date_str);
> > //TODO: coreutils 6.9 also accepts "yyyy-mm-dd HH" (no minutes)
>
> ...and here you fall through to code which tries to parse seconds,
> which is wrong.
>
> > } else {
> > bb_error_msg_and_die(bb_msg_invalid_date, date_str);
>
>
>
> Applied with some changes. Thanks!
Thanks for corrections!
Regards,
--
Alex
_______________________________________________
busybox mailing list
[email protected]
http://lists.busybox.net/mailman/listinfo/busybox
