On Monday 29 March 2010 17:55, Chris Metcalf wrote: > The appended diffs fix a couple of minor test suite issues I've seen > getting the test suite to work with our config file. These diffs are > against 1.16.1 with plain diff, rather than a proper git diff; I > apologize but I have some other fire-fighting to do at the moment and > am still coming up to speed on git. > > The changes are: > > - cp-parents requires FEATURE_CP_LONG_OPTIONS > - grep NUL testing requires EXTRA_COMPAT > - mount.tests requires MINIX > - tar.tests requires FEATURE_TAR_LONG_OPTIONS > - runtest needs to handle multiple FEATURE lines correctly > > Note that in grep.tests I put a hardcoded "SKIP=" after the block of > tests guarded by the "optional EXTRA_COMPAT"; there doesn't seem to be > a shell function for "reset to non-optional testing". Perhaps there > should be a "required" function (parallel to "optional") that just > does "SKIP="? I suppose alternately you could just require that all > optional tests follow all required tests, and move the "grep NUL" > tests down to later in grep.tests. > > There also isn't an explicit way to bail out completely if "SKIP" is > set by an "optional" line, as I do in mount.tests to avoid running > mkfs explicitly and failing, but perhaps the idiom I used is sufficient.
Applied, thanks! > I also have marked the "pidof -s" tests as "buggy" in our tree, though > I don't include those diffs here. The concern is that if you have an > init that is running "askfirst" somewhere, it will fork and wait, and > then you will have multiple "init" processes, and "pidof -s init" will > report the wrong process and the test will fail. I'm not sure what > better solution to suggest; "pidof -s kthreadd" = 2 perhaps? No idea so far... -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
