On Sunday 27 June 2010 01:01, Ladislav Michl wrote: > On Fri, Jun 25, 2010 at 04:08:00PM +0200, Bernhard Reutner-Fischer wrote: > > On Fri, Jun 25, 2010 at 04:18:06PM +0200, Ladislav Michl wrote: > > >From: Ladislav Michl <[email protected]> > > > > > >Use DEFAULT_SHELL instead of literal "/bin/sh". > > > > oh and for the archival part you could perhaps > > run_shell(DEFAULT_SHELL,0,archive_handle->tar__to_command,NULL); > > iff that's smaller. > > > > just a thought.. > > Well, it is smaller: > text data bss dec hex filename > 717606 2121 9088 728815 b1eef busybox > 717580 2121 9088 728789 b1ed5 busybox.run_shell > > ...but run_shell: > - claims "Run SHELL, or DEFAULT_SHELL if SHELL is empty.", but I dont see it > implemented in the code.
Fixed. > - allocates memory, which may be leaked on no mmu systems. > (and btw, why is xstrdup needed at all? > args[0] = bb_get_last_path_component_nostrip(xstrdup(shell));) Fixed - removed this xstrdup. -- vda _______________________________________________ busybox mailing list [email protected] http://lists.busybox.net/mailman/listinfo/busybox
